fix: implement bank name provider and used a def function for en_GB l…#2332
Closed
reory wants to merge 1 commit into
Closed
fix: implement bank name provider and used a def function for en_GB l…#2332reory wants to merge 1 commit into
reory wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocale
What does this change
Implemented the bank() method for the en_GB locale and added a standardised list of major UK Banks.
What was wrong
The en_GB locale claimed to support the bank() method (as seen in the bban_format) however the provider was missing banks data tuple and the corresponding method, leading to missing or incorrect data generation.
Description of the root cause of the issue.
How this fixes it
Description of how the changes fix the issue.
Fixes #2280
AI Assistance Disclosure (REQUIRED)
Checklist
make lintI've been using Faker extensively in my own projects—most recently for a Invoice Fraud Detection Service https://github.com/reory/Invoice-Fraud-Detector-Service
where I used it to generate synthetic invoice data. I noticed the en_GB bank provider was missing while working on UK-specific datasets, so I'm happy to give back to a library that has been so helpful for my junior backend development work!
Thanks for maintaining such a great tool.