Drop support for Python 3.8 #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only other place is in |
|
I think I found a bit more. In fact I think it's possible to get rid of typing-extensions now as well. I've done this here, but it could be moved to another PR if you'd prefer. |
fcurella
requested changes
Feb 10, 2025
fcurella
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Drops support for Python 3.8
What was wrong
EOL Python version still supported.
How this fixes it
Dropped various references to Python 3.8.
I explicitly didn't check if there's any code that can be cleaned up. Maybe good to run pyupgrade on it and see what happens?
Checklist
make lint