-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added person provider for gu_IN locale with tests #2111
Added person provider for gu_IN locale with tests #2111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the locale code for Gujarati gu
instead of gj
?
https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=gu
The error seems to be related to the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@fcurella It's a debatable topic, but I believe it should be kept as
I also saw that it's added as Would like to know your thoughts on this. We should probably keep it consistent everywhere and I'm inclined towards |
We are talking just about the language, not the state.
We follow [ISO-639](
https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=gu),
where it’s defined as `gu`. Every other place where the language code used
is `gj` is incorrect and needs to be fixed.
…On Sun, Oct 13, 2024 at 4:37 PM wh0am1 ***@***.***> wrote:
@fcurella <https://github.com/fcurella> It's a debatable topic, but I
believe it should be kept as gj and not gu. The reasons are
- number plates use GJ
- it's already mentioned as GJ in State Abbr variable
<https://github.com/joke2k/faker/blob/master/faker/providers/address/en_IN/__init__.py#L407>
- Indian Gov website
<https://slusi.da.gov.in/watershedatlas/list_of_state_abbreviation.htm>
mentioning state abbr also says GJ
I also saw that it's added as gu in language_local_codes
<https://github.com/joke2k/faker/blob/master/faker/providers/__init__.py#L156>
.
Would like to know your thoughts on this. We should probably keep it
consistent everywhere and I'm inclined towards GJ
—
Reply to this email directly, view it on GitHub
<#2111 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAV4BZ5JWJ6LWVVSVOPTGLZ3LR2TAVCNFSM6AAAAABPGQ7XWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBZGE2DAMZYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
What does this change
Added male and female names with prefixes for gu_IN
Added tests for person provider
What was wrong
There was no person provider for gu_IN locale
Fixes #2106
Checklist
make lint