Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added person provider for gu_IN locale with tests #2111

Conversation

debjeetsingha
Copy link
Contributor

@debjeetsingha debjeetsingha commented Oct 1, 2024

What does this change

Added male and female names with prefixes for gu_IN
Added tests for person provider

What was wrong

There was no person provider for gu_IN locale

Fixes #2106

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have run make lint

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the locale code for Gujarati gu instead of gj?

https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=gu

@debjeetsingha debjeetsingha changed the title Added person provider for gj_IN locale with tests Added person provider for gn_IN locale with tests Oct 5, 2024
@debjeetsingha
Copy link
Contributor Author

debjeetsingha commented Oct 5, 2024

The error seems to be related to the use of functools.cache, which was introduced in Python 3.9. However, Python 3.8 does not support this feature.
Related to issue #2112

@fcurella fcurella changed the title Added person provider for gn_IN locale with tests Added person provider for gu_IN locale with tests Oct 7, 2024
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wh0th3h3llam1
Copy link
Contributor

wh0th3h3llam1 commented Oct 13, 2024

@fcurella It's a debatable topic, but I believe it should be kept as gj and not gu. The reasons are

I also saw that it's added as gu in language_local_codes.

Would like to know your thoughts on this. We should probably keep it consistent everywhere and I'm inclined towards GJ

@fcurella
Copy link
Collaborator

fcurella commented Oct 13, 2024 via email

@fcurella fcurella merged commit 55ccb6f into joke2k:master Oct 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add provider gj-IN for Gujarati language
3 participants