Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Providers for ka_GE language #2110

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Added Providers for ka_GE language #2110

merged 4 commits into from
Oct 15, 2024

Conversation

onesch
Copy link
Contributor

@onesch onesch commented Oct 1, 2024 •
edited
Loading

What does this change

New providers have been added: date_time, phone_numbers, job and colors for the ka_GE language.

What was wrong

this localization did not exist

How this fixes it

I added providers along the following paths:

faker/providers/color/ka_GE/__init__.py
faker/providers/date_time/ka_GE/__init__.py
faker/providers/job/ka_GE/__init__.py
faker/providers/phone_number/ka_GE/__init__.py

Checklist

  • I have read the documentation about CONTRIBUTING
  • I have run make lint

fcurella
fcurella requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

@onesch
Copy link
Contributor Author

onesch commented Oct 4, 2024 •
edited
Loading

I wrote tests.
but I encountered an error, the same as in #2112.

fcurella
fcurella approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank y ou!

@onesch
Copy link
Contributor Author

onesch commented Oct 7, 2024

Went well, please accept. 🙂

@onesch onesch changed the title Added Providers for ka_GE language Added Providers for ka_GE language Oct 9, 2024
@fcurella fcurella merged commit 53995d1 into joke2k:master Oct 15, 2024
28 checks passed
@onesch onesch deleted the add-georgian-localization branch October 30, 2024 13:09
@onesch onesch restored the add-georgian-localization branch October 30, 2024 13:12
@onesch onesch deleted the add-georgian-localization branch October 30, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella fcurella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onesch @fcurella