4 new features addded | Better algo

[Ysajid]

No description provided.

[jojoee]

In reviewing.
Thank you for contribution,
will provide feedback within this Sunday (5 March).

[Ysajid]

Welcome 😄

[Ysajid]

@jojoee also check the new commits

[jojoee]

Hi Ysajid, hope you are well.
All these below is a my opinion
to try to making a good + maintainable software.
If you found something I miss or disagree with it,
please letting me know, and I'm happy to discuss about it.

I've reviewed your repository at commit no 51f83f1
and this is my step to review your PR.

1. Clone the respo
2. Run bower install & npm install
3. Review

Review notes

1. Text is not displayed on initial state on image/screen
   Need to click "Font Size" at least 1 time before I can see the text.
   It's seem you missing default font size variable.

2. "Drag and drop image here or provide image url" is not working

3. Color palette / Font Color
   In my opinion, if we want to change color.
   It good to have some color palette but
   it will better if we add "color-picker" instead.

4. Font family "Ubuntu" is not working

5. If you say, you complete "Support multi-lines" in TODO list.
   I think we should remove "Support 5 maximum lines" in "Note" section
   and also provide a maximum line in "Note" section.

6. Some asset files is not supposed to be added in repository
   Cause we can using it via bower or CDN to keep repository small as possible
   and we don't have to maintain it.

• css/bootstrap.min.css
• js/canvas-to-blob.min.js
• js/filesaver.min.js
• js/jquery-3.1.1.min.js
• js/webfont.js

7. Big binary files not supposed to be added.
   In my opinion, all items in repository should be source-code or
   some mini binary file (e.g. images/page-avatar.png).
   If you want to using it for demo purpose, it better to using 3rd party instead
   (e.g. https://unsplash.it/, http://lorempixel.com/).

• images/1.jpg
• images/2.jpg
• images/3.jpg

8. Code style
   It better to follow existing code style and make it consistency
   so, we can track each change for each commit easier.

• css/style.css, separate each rule with 1 line
• index.html, currently we using 2 spaces for indent.
• js/main.js, in javascript file, we mostly follow https://github.com/airbnb/javascript.
  and we using snake_case + UPPER_CASE for global variable.

9. Commit message should provide more detail
   (e.g. "bug fix" on commit no 73fe274)

10. Remove commented-code if we don't using it
    (e.g. js/main.js)

11. I think it's better to PR small change instead a big change.

I'm sorry that I have not note a contribution guideline but
anyway I'm thank you, you interested/contributed the repository.

Cheer,
Nathachai.

[Ysajid]

Thanks for the feedback 😄

I'm not sure about the option to use custom image [drag&drop or browse button].
I'll fix the other stuffs.

And it's my first time sending any PR to any repository.
Please feel free to give any suggestions.

[jojoee]

Cheers :)