Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added draw all and sort in case of decks.length > 1 #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dado21780
Copy link

added draw all and sort in case of decks.length > 1
also added a minor typo fix in decks and a proposal for how to structure the monster stats...
if we ever get there with the time at hand :)

@GinoGalotti
Copy link
Collaborator

Would be awesome having the monster stats as well but... that sounds overkill. It would need a way to display the stats

@mwinckler
Copy link
Collaborator

This PR seems to have slipped through the cracks. Do we want to take these changes (in which case we need to rebase and clean up), or not (in which case we should close this PR)?

@GinoGalotti
Copy link
Collaborator

We can try to recycle the idea. Draw all is something similar to what End_of_round does... but it also organises them by initiative. I really like the last idea, maybe we could sort the decks every turn in initiative order.

But bringing these changes to master might need loads of changes. And the draw all carries a problem that I haven't found a solution yet (that's why I'm not pushing for the end_of_round change): When you kill all the monsters for a type, and you want to disable the deck so it stays in the same state till you face more of those monsters!

@Krizzzn
Copy link
Contributor

Krizzzn commented Jan 10, 2018

I've implemented an automatic sorting feature for the ability decks, that will sort all unused decks to the end. Less scrolling!
Maybe you can build the sort by initiative feature on top of that once I open a pull request (or if you like I can also implement this in my branch).
But before I open a PR I want to play a round with this change as it changes the basic behavior of the app. The feature tries to figure out the unused decks automatically.
(see draft here: https://github.com/Krizzzn/gloomycompanion/tree/feature-autosort)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants