Skip to content

Improve search flexibility#78

Merged
johnwmillr merged 4 commits into
masterfrom
improve-search-flexibility
Dec 17, 2018
Merged

Improve search flexibility#78
johnwmillr merged 4 commits into
masterfrom
improve-search-flexibility

Conversation

@johnwmillr
Copy link
Copy Markdown
Owner

Resolves #67 by searching through all results in search_artist and using the search_genius_web endpoint in search_song.

The search_genius_web endpoint is used on the Genius.com and is much more flexible with spelling errors. However, this endpoint is not a part of the supported Genius API, and as a result may be less reliable. The search_song method falls back on a _search_song_old method now if the search_genius_web call fails.

@johnwmillr johnwmillr self-assigned this Dec 17, 2018
@johnwmillr johnwmillr merged commit 0a119a4 into master Dec 17, 2018
@johnwmillr johnwmillr deleted the improve-search-flexibility branch December 17, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant