Fixed issues in #126#170
Merged
Merged
Conversation
* added auth * added voting methods for annotations * renamed client_access_token to access_token * added documentation for authorization, renamed all instances of client_access_token to access_token * fixed instance parse_redirected_url didn't work with 'token' flow * added OAuth2 documentation, modified OAuth2 to make it user-friendlier * removed Authenticating yourself from snippets, added missing commas * Revert "removed Authenticating yourself from snippets," This reverts commit d2e99bb. * added missing comma * added more missing commas * added missing word in sippets * changed get_user_auth_url to auth.url property, changed 'all' scope type to tuple, fixed combining scopes (changed ',' to ' ') * changed calling get_user_auth_url to url * fixed client_only_app not in OAuth2 attributes * fixed parse_redirected_url * set None in POST body params when optional annotation parameteres aren't supplied * revert to current _make_request * fixed typo * added some docs, fixed new methods' payload * fixed response for 204 response, added tests * fixed added test bugs * fixed update_annotation and added its test, added docs for contributing * added example redirect uri to snippets * commit changes * add text_format to API annotation methods * fixed prompt_user bug * fix flake8 error * fixed bugs, added auth tests * fix test_url error * fix wrong function name * removed test_url Co-authored-by: John W. Miller <johnwmillr@users.noreply.github.com>
- removed binary encoding - genius.tag(): replaced unicodedata.normalize with only replacing \xa0 - fixed IndentationError - __main__: made import relative
johnwmillr
approved these changes
Nov 8, 2020
Owner
johnwmillr
left a comment
johnwmillr
left a comment
There was a problem hiding this comment.
Good PR, thank you for the quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utf-8when saving filesgenius.tag(): replacedunicodedata.normalizewith only replacing\xa0IndentationError__main__.py: made import relative