Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature2vector] fixed bug in cloning features #48

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[feature2vector] fixed bug in cloning features #48

merged 2 commits into from
Jul 3, 2024

Conversation

johntruckenbrodt
Copy link
Owner

This lead to a segmentation fault in a case where a geometry was loaded from file, cloned, and then got fields added to it.

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9781127716

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.266%
Totals Coverage Status
Change from base Build 9781110126: 0.02%
Covered Lines: 1858
Relevant Lines: 2344
💛 - Coveralls

@johntruckenbrodt johntruckenbrodt merged commit d7f00d3 into main Jul 3, 2024
4 checks passed
@johntruckenbrodt johntruckenbrodt deleted the bugfix/vector_clone branch July 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johntruckenbrodt @coveralls