Skip to content

fix: build failures on project with greater sdk versions #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

adityamohta
Copy link
Contributor

Issue

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':tasks'.
> Could not create task ':react-native-sound-player:compileDebugJavaWithJavac'.
   > In order to compile Java 9+ source, please set compileSdkVersion to 30 or above

@adityamohta
Copy link
Contributor Author

I use this in one of my projects, I love it.

It would be great to get a review here from a maintainer if possible.
I think this could be a good way to handle requirements for different projects, so the version is not pinned down, however happy to hear other views.

Possibly @johnsonsu if you wouldn't mind.

And, thank you for all the hard work on this lib, it's really useful. 🙌

@johnsonsu
Copy link
Owner

Thank you for your contribution!

@johnsonsu johnsonsu merged commit 231540e into johnsonsu:master Jun 3, 2024
@adityamohta
Copy link
Contributor Author

Thank you for taking out time to review, I really appreciate it! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants