Repository navigation
Mark nodes promoted to OOTB as obsolete - #111
Open
sharafutdinovdi wants to merge 1 commit into
Open
sharafutdinovdi wants to merge 1 commit into
sharafutdinovdi wants to merge 1 commit into
Conversation
Sheets and View Family Types dropdowns and View.Origin now exist as out-of-the-box nodes in Dynamo for Revit, so mark the Rhythm versions obsolete following the existing deprecation pattern. Remaining items from the deprecation list are covered in johnpierson#24.
24 of 30 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24. Three of the remaining unticked items now exist as out-of-the-box nodes in Dynamo for Revit, so this marks the Rhythm versions obsolete following the existing pattern in the repo:
Sheetsdropdown (RhythmUI) → OOTBSheets(Revit > Selection), marked with[Obsolete]as inLinkSelectionMethods.csView Family Typesdropdown (RhythmUI) → OOTBView Family Types(Revit > Selection), same patternView.Origin(RhythmRevit) → OOTBView.Originproperty, marked with[IsObsolete("Node removed, use the OOTB nodes, View.Origin")]as inTag.csNot touched:
View.SetCropRegionis already commented out;Tag.SetLeaderElbow/Tag.SetLeaderEndhave no Rhythm implementation in the current source (theLeaders.*nodes operate onLeaderobjects, not tags), so those two items look like bookkeeping on the list rather than code changes. Details in the comment on #24.Built
RhythmRevitandRhythmUIlocally with theRelease R25configuration (MSBuild, Visual Studio 2022): 0 errors.