Bump to PHPUnit 6, PHP 7, drop dead code #25
Conversation
…ed dead code, travis: cleanup
|
|
||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| final class SlowTest extends TestCase |
There was a problem hiding this comment.
why is this final? (and SpeedTrapListener)
There was a problem hiding this comment.
The best practice to prevent inheritance. Do you need it?
I learn a lot from this post: http://ocramius.github.io/blog/when-to-declare-classes-final/
There was a problem hiding this comment.
interesting article. no i don't need inheritance from SpeedTrapListener, though if the class is final then the only way to change behaviour is to fork your own version because there is no way to inject new behaviour (eg to change output format).
i wonder if ocramius' comments apply more to code within a larger project rather than packages/components? but thats a philosophical debate for another time... no reason to hold up release.
thanks for all you have done here BTW. nice work.
|
@TomasVotruba Thanks again for showing off all the small improvements we could make! I have merged PHPUnit 6.0 support to master branch. If you're still interested in adding some of these ideas could you open smaller more focused PR's against latest master? Based on the work in this PR we could do these changes in separate PRs:
Let's preserve the direction the master branch is in regarding phpunit.xml, Travis config, classes are not defined final, class method and property visibility remains the same, etc. Feel free to focus on the above PRs! |
|
@johnkary Thanks for the message. I realize I made too many changes. I'll look on those 2 PRs. Or could you send them? I'm in a bit lack of free time now. |
|
@TomasVotruba I will focus on two new features for slowness threshold per-testsuite and per-group. If you have not had time to work on them by then I'll submit PRs. Thanks! |
|
@johnkary Thank you! |
3 participants
Ref #24
Here are few suggestions to improve code. I noticed there is lot of dead code.
Also mixed PSR-0 and PSR-4 structures was fixed.
And add usage of short arrays
[], isset operator??, return type hints, strict type hints.What do you think about this? Feel free to comment particular commits.