Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client side templates #292

Closed
wants to merge 7 commits into from
Closed

Conversation

johnbillion
Copy link
Owner

See #291.

This begins the process of switching to client side Underscore templates while retaining the ability for any outputter to continue using server side HTML generation.

The first panel to be switched over to an Underscore template is the Admin Screen panel.

array( 'jquery' ),
array(
'jquery',
'wp-util',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should either add underscore or remove jquery, as wp-util depends on both.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll add Underscore so the dependencies are more explicit.

@tomjn
Copy link
Contributor

tomjn commented May 4, 2018

Doing this via React or Vue might make more sense, QM can output the entire debug info to be displayed as JSON and it be passed down the hierarchy, the only things that need state being hiding one panel and showing another.

Also, using underscores templates brings with it the problem that content security policies can't remove unsafe eval etc on the frontend

@johnbillion
Copy link
Owner Author

I wanted to avoid loading another dependency that isn't included in WordPress, but you're right that React or Vue would be a better choice.

This is on hold at the moment anyway.

@johnbillion johnbillion removed this from the Future milestone May 6, 2018
@johnbillion johnbillion closed this May 6, 2018
@lkraav
Copy link

lkraav commented Jul 24, 2018

I wanted to avoid loading another dependency that isn't included in WordPress, but you're right that React or Vue would be a better choice.

React will be shipping w/ Gutenberg soon enough. At least the dependency shipping problem looks solved.

@johnbillion johnbillion deleted the feature/html-templates branch May 14, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants