Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using stubs for the correct version of WordPress being tested #16

Closed
wants to merge 2 commits into from

Conversation

johnbillion
Copy link
Owner

No description provided.

Comment on lines +69 to +76
run: |
if [ "${{ inputs.wp }}" == "latest" ]; then
composer install --dev --prefer-dist
elif [ "${{ inputs.wp }}" == "nightly" ]; then
composer require --dev --update-with-dependencies --prefer-dist roots/wordpress-full="dev-main"
else
composer require --dev --update-with-dependencies --prefer-dist roots/wordpress-full="~${{ inputs.wp }}.0" php-stubs/wordpress-stubs="~${{ inputs.wp }}.0"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: |
if [ "${{ inputs.wp }}" == "latest" ]; then
composer install --dev --prefer-dist
elif [ "${{ inputs.wp }}" == "nightly" ]; then
composer require --dev --update-with-dependencies --prefer-dist roots/wordpress-full="dev-main"
else
composer require --dev --update-with-dependencies --prefer-dist roots/wordpress-full="~${{ inputs.wp }}.0" php-stubs/wordpress-stubs="~${{ inputs.wp }}.0"
fi
if: "${{ inputs.wp == 'latest' }}"
run: "composer update --prefer-dist"
- name: "Install nightly dependencies"
if: "${{ inputs.wp == 'nightly' }}"
run: |
composer update --dev --with-all-dependencies --prefer-dist roots/wordpress-full:"dev-main"
- name: "Install dependencies"
if: "${{ inputs.wp != 'nightly' && inputs.wp != 'latest' }}"
run: |
composer update --dev --with-all-dependencies --prefer-dist roots/wordpress-full:"~${{ inputs.wp }}.0" php-stubs/wordpress-stubs:"~${{ inputs.wp }}.0"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your repos don't have lock files. So install will display a warning.

@johnbillion
Copy link
Owner Author

I'd love to do this but there's too many issues with dependency conflicts and unreliability of the older stubs. Closing this off, for now at least.

@johnbillion johnbillion closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants