Show warning regarding PHP 8.4 support (laravel#312)

* Show warning regarding PHP 8.4 support * Fix workflows * Update DefaultCommand.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
johnbacon · Nov 29, 2024 · 43a25d9 · 43a25d9
1 parent fc6a920
commit 43a25d9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -50,6 +50,11 @@ jobs:
           composer install
 
       - name: Execute lint tests with Laravel preset
+        if: matrix.php == '8.4'
+        run: PINT_IGNORE_ENV=1 ./pint --test
+
+      - name: Execute lint tests with Laravel preset
+        if: matrix.php != '8.4'
         run: ./pint --test
 
       - name: Execute static analysis

diff --git a/app/Commands/DefaultCommand.php b/app/Commands/DefaultCommand.php
@@ -57,6 +57,14 @@ protected function configure()
      */
     public function handle($fixCode, $elaborateSummary)
     {
+        if (! ($_ENV['PINT_IGNORE_ENV'] ?? false) && version_compare(PHP_VERSION, '8.4.0', '>=')) {
+            $this->warn('PHP 8.4 is not currently supported by PHP CS Fixer and you may encounter unexpected behavior.');
+            $this->warn('You can still force Pint to run by setting the environment variable:');
+            $this->warn('PINT_IGNORE_ENV=1 vendor/bin/pint');
+
+            return 1;
+        }
+
         [$totalFiles, $changes] = $fixCode->execute();
 
         return $elaborateSummary->execute($totalFiles, $changes);