Transform initializers for private named instance fields #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheiber
reviewed
Oct 15, 2018
| @@ -346,14 +346,15 @@ namespace ts { | |||
| } | |||
|
|
|||
| function transformClassMembers(node: ClassDeclaration | ClassExpression, isDerivedClass: boolean) { | |||
| // Declare private names. | |||
| const privateProperties = filter(node.members, isPrivatePropertyDeclaration); | |||
There was a problem hiding this comment.
since private-named-fields aren't properties, what about privateNamedField?
joeywatts
force-pushed
the
esnext-private-fields-weakmaps
branch
from
e3ff684 to
b362de1
Compare
joeywatts
force-pushed
the
esnext-private-fields-initializers
branch
2 times, most recently
from
c1fdf9a to
0c65c27
Compare
joeywatts
force-pushed
the
esnext-private-fields-weakmaps
branch
from
688d51c to
6baf417
Compare
added 2 commits
October 25, 2018 13:46
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
Signed-off-by: Joseph Watts <jwatts43@bloomberg.net>
joeywatts
force-pushed
the
esnext-private-fields-initializers
branch
from
0c65c27 to
cdfb649
Compare
|
closed (refer to bloomberg#15) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.