Use the same interpreter when ptw is called outside of a virtual env #72
Conversation
|
👍 Thanks for the fix! |
|
Nice one @jacebrowning 👍 |
| @@ -1,6 +1,7 @@ | |||
| pytest-watch Changelog | |||
| ====================== | |||
|
|
|||
| - Enhancement: Use the same Python interpreter for `py.text` when `ptw` is run outside of an activated virtual environment. | |||
There was a problem hiding this comment.
s/text/test/ ?!
Also s/py.test/pytest/ then.
|
Really? |
|
@blueyed Looks like it's the other way around. @jacebrowning Just curious to hear your rationale. Any specific reason you kept |
| return custom.split(' ') | ||
| if os.getenv('VIRTUAL_ENV'): | ||
| return ('py.test',) | ||
| return (sys.executable, '-m', 'pytest') |
There was a problem hiding this comment.
Just tested this locally. Got TypeError: can only concatenate tuple (not "list") to tuple because lists were used outside this function.
I just patched this in f4814f9.
@joeyespo Simply to leave the existing behavior unchanged. I also noticed that pytest-watch prints the full command it's running for pytest, which might introduce some confusing noise to users that were used to seeing a simple "Running py.test" message. |
|
Why would Maybe it should only fall back to |
|
@lwm |
I just found this pull request through some searching and was happy to see someone put some time in and decided to show some gratitude! In retrospect, I am glad I also provoked your usual high quality code review 😄. |
My primary use case here is
pipenv. I would like to be able to do:But this attempts to find a globally installed pytest:
With this change, pytest-watch will call pytest as a module if not currently running in an activated virtual environment. This should also make running pytest-watch globally a nicer experience by ensuring the same Python interpreter is used to run both
ptwandpy.testeven if the user's shell is misconfigured.