Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for pdb if it's passed to pytest_args #64

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Wait for pdb if it's passed to pytest_args #64

merged 1 commit into from
Jun 16, 2016

Conversation

remcohaszing
Copy link
Contributor

This prevents multiple pdb sessions from running simultaneously when
running:

    pytest-watch -- --pdb

Previously this could result into annoying behaviour.

This prevents multiple pdb sessions from running simultaneously when
running:

        pytest-watch -- --pdb
@blueyed
Copy link
Collaborator

blueyed commented Jun 16, 2016

LGTM, I think this bugged my already a few times.

@joeyespo
Copy link
Owner

joeyespo commented Jun 16, 2016

Why not run pytest-watch --pdb instead? That was added in to handle this case.

I'm all for reducing frustration and confusion though 👍 And this is well-aligned with #57.

Thanks, @remcohaszing!

@joeyespo joeyespo merged commit 10d1b75 into joeyespo:master Jun 16, 2016
@remcohaszing
Copy link
Contributor Author

Because it takes so many keypresses to properly modify ptw -- --maxfail 1 -vv ;)

@blueyed
Copy link
Collaborator

blueyed commented Jun 16, 2016

@remcohaszing
You can use -x instead of --maxfail 1 btw (AFAICS).

@remcohaszing
Copy link
Contributor Author

@blueyed I didn't know, thanks for the tip. 😸

@joeyespo joeyespo added the bug label Jun 21, 2017
@max-sixty max-sixty mentioned this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants