Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the Makefile figure out which version of Go to download #74

Merged
merged 2 commits into from
Jul 14, 2014

Conversation

kfl
Copy link
Contributor

@kfl kfl commented Jul 10, 2014

The Makefile should figure out which file to download given only the Go version number.

I've modified the Makefile to derive the right name of the Go release file based on the information from uname. I seems to work on the two computers I have access to (one Linux and one OS X).

Current limitations:

  • Only tested with Linux and OS X
  • Special handling of OS X which might be too fragile to be future proof.

@asergeyev
Copy link
Collaborator

Just curious, why wget instead of curl? Looks fine, I will merge it in couple of days unless there are objections.

asergeyev added a commit that referenced this pull request Jul 14, 2014
Let the Makefile figure out which version of Go to download
@asergeyev asergeyev merged commit 737c0b5 into joewalnes:master Jul 14, 2014
@kfl
Copy link
Contributor Author

kfl commented Jul 14, 2014

I usualy don't have any strong preferences for wget over curl. But In this case wget followed the redirect from http://golang.org/dl whereas curl just returned an HTML file. I'm sure that curl can be used instead of wget, I just knew the wget command line options better 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants