Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for hack lang #337

Merged
merged 15 commits into from
Jan 28, 2019
Merged

Add examples for hack lang #337

merged 15 commits into from
Jan 28, 2019

Conversation

azjezz
Copy link
Contributor

@azjezz azjezz commented Jan 26, 2019

No description provided.

@asergeyev
Copy link
Collaborator

I would appreciate someone with hack coding experience to write up their opinion. If nothing happens I'll probably merge this anyway.

@azjezz
Copy link
Contributor Author

azjezz commented Jan 28, 2019

cc @fredemmott @usox

usox
usox suggested changes Jan 28, 2019
View reviewed changes
Copy link

@usox usox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the Entrypoint thingy, it seems to be ok. But someone should rebase all those single commits ;)

examples/hack/count.hh Show resolved Hide resolved
examples/hack/dump-env.hh Outdated Show resolved Hide resolved
@azjezz
Update count.hh
e640cce 
`count` is a built-in function so we can't use that for a name
@asergeyev
Copy link
Collaborator

But entrypoint thing stays then? Will it work @usox ?

I second desire to ask for rebase/squash and have less commits, could you do this @azjezz? I can squash it on merge but that'll stripe authoring.

@azjezz
Copy link
Contributor Author

azjezz commented Jan 28, 2019

@usox @asergeyev __EntryPoint attribute works as of 3.30 which is the version stated in the README.
i would say squash and merge :P

@asergeyev
Copy link
Collaborator

Thanks

@asergeyev asergeyev changed the title Add examples for hack lang Add examples for hack lang (thanks @azjezz) Jan 28, 2019
@asergeyev asergeyev merged commit 5c11ca2 into joewalnes:master Jan 28, 2019
@asergeyev asergeyev changed the title Add examples for hack lang (thanks @azjezz) Add examples for hack lang Jan 28, 2019
fredemmott
fredemmott reviewed Jan 28, 2019
View reviewed changes
examples/hack/count.hh
);

// usleep is builtin, it is not an async builtin - so it also must block the main request thread
usleep(500000);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HH\Asio\usleep()

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a side note, async is not multithreading. Some async operations may use threading as an implementation detail, but in general (and for IO specifically), it's single-threaded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here : #340

@azjezz azjezz mentioned this pull request Jan 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredemmott fredemmott fredemmott left review comments

@usox usox usox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azjezz @asergeyev @fredemmott @usox