Skip to content

Clean up (mostly PEP8) #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

Conversation

rickhanlonii
Copy link
Collaborator

Overview

This PR cleans up some of the code, mostly PEP8 and typos.

oauth_request = oauth.OAuthRequest.from_consumer_and_token(consumer,
token=token, http_method='POST', http_url=RESOURCE_URL,
parameters=parameters)
token=token, http_method='POST', http_url=RESOURCE_URL,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • E501 line too long (118 > 79 characters)

self.assertEqual(req.normalized_url, 'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')
self.assertEqual(req.url, 'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')
self.assertEqual(req.normalized_url,
'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • E501 line too long (97 > 79 characters)

@rickhanlonii
Copy link
Collaborator Author

@jaitaiwan, tests fixed.

@@ -848,7 +871,8 @@ def test_get_normalized_parameters_ignores_auth_signature(self):
'oauth_timestamp': "137131200",
'oauth_consumer_key': "0685bd9184jfhq22",
'oauth_signature_method': "HMAC-SHA1",
'oauth_signature': "some-random-signature-%d" % random.randint(1000, 2000),
'oauth_signature': "some-random-signature-%d" % random.randint(1000,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • E501 line too long (80 > 79 characters)

self.assertEqual(req.normalized_url,
'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')
self.assertEqual(req.url,
'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • E501 line too long (97 > 79 characters)

self.assertEqual(req.normalized_url, 'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')
self.assertEqual(req.url, 'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')
self.assertEqual(req.normalized_url,
'http://social.yahooapis.com/v1/user/6677/connections;start=0;count=20')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • E501 line too long (97 > 79 characters)

@TimSC
Copy link
Contributor

TimSC commented Jan 13, 2018

I pulled this PR into a new fork: https://github.com/TimSC/python-oauth10a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants