Skip to content

IMAP4_SSL.authenticate() wrapper should return (status, data) #101

Open
@kkurian

Description

@kkurian

in clients/imap.py:

    imaplib.IMAP4_SSL.authenticate(self, 'XOAUTH',
        lambda x: oauth2.build_xoauth_string(url, consumer, token))

should read:

    return imaplib.IMAP4_SSL.authenticate(self, 'XOAUTH',
        lambda x: oauth2.build_xoauth_string(url, consumer, token))

Without this change the oauth2 IMAP4_SSL.authenticate() method does not mimic the return behavior of its imaplib counterpart and, what's worse, the return values from imaplib are lost.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions