Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved links to MADR, added one template #62

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

socadk
Copy link
Contributor

@socadk socadk commented Apr 4, 2023

No description provided.

@joelparkerhenderson
Copy link
Owner

Thanks! I see the PR has a different things mixed together.

For the new info, that's good. Would you like to do a PR for just that, so you get credit for it? Or if you prefer I can just add it on my side.

For the MADR-related items, those aren't OK as is. MADR is the author's abbreviation, and the related tool name is "madr", and the GitHub link uses "madr". This repo's links and template are using "MADR" in order to match the author's abbreviation.

The author and I have been in touch for many years, and MADR is what the MADR author requested of me. If the author wants a change, I'll of course do it.

Copy link
Contributor

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a chat with @socadk. Updates will follow.

README.md Outdated
* [Decision record template for MADR](templates/decision-record-template-madr/index.md)
* [Decision record template in Markdown](templates/decision-record-template-madr/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a discussion with @socadk:

How about "Decision record template of the MADR project"?

README.md Outdated
@@ -231,7 +232,7 @@ ADR example templates that we have collected on the net:

* [ADR template for business case](templates/decision-record-template-for-business-case/index.md) (more MBA-oriented, with costs, SWOT, and more opinions)

* [ADR template MADR](templates/decision-record-template-madr/index.md) (more Markdown)
* [ADR template MADR](templates/decision-record-template-madr/index.md) (Markdown Any/Architectural Decision Records)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our proposal:

[ADR template Markdown Any Decision Records (MADR)](templates/decision-record-template-madr/index.md) (both simple and elaborate version; the latter emphasizes options and their pros and cons)

@socadk
Copy link
Contributor Author

socadk commented Apr 19, 2023

Thanks for the feedback to both of you, I have changed the patch-1 branch accordingly. I can also create a new separate PR if that helps.

The README also has a section "Suggestions for writing good ADRs", I recently wrote on this topic here: https://ozimmer.ch/practices/2023/04/03/ADRCreation.html (just FYI, comments welcome).

@joelparkerhenderson joelparkerhenderson merged commit 8231945 into joelparkerhenderson:main Apr 19, 2023
@joelparkerhenderson
Copy link
Owner

Good thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants