Normalize/canonicalize relative source paths (and remove extra underscore classes that appear when using a relative source path) #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he extra "underscore" classes that get generated with a relative source path.
joelittlejohn
changed the title
|
Thanks for the fix! Much appreciated. |
|
Sure thing. Wish I could figure out a good way to test it. I found this one out the hard way because our build system is set with a maven basedir with "/./" in it... so I'm motivated to get it fixed! |
joelittlejohn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FilenameUtils to fix relative source paths in the maven plugin. This in turn fixes the extra "underscore" classes that get generated with a relative source path.