Corrected Exclude pattern behavior with Maven to avoid excluding all files #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrimble
force-pushed
the
feature_recursive-include-patterns
branch
from
e2ec190 to
a850629
Compare
ctrimble
force-pushed
the
feature_recursive-include-patterns
branch
from
acde93a to
f3c8ded
Compare
|
@joelittlejohn I have finished my changes for this PR and it is ready for review. I left this as 2 commits, since there are 2 distinct changes coming in. |
joelittlejohn
added a commit
that referenced
this pull request
Apr 29, 2015
Corrected Exclude Pattern Behavior with Maven.
joelittlejohn
changed the title
joelittlejohn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default set of exclude directories was causing all files to be excluded. This corrects that issue and adds tests related to the default exclude list. This is related to #332.
This PR also adds the default set of maven excludes anytime the sourceDirectory property is supplied without the sourcePaths property.