Skip to content

fix(CLOB): clob values had wrong values #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2014

Conversation

realityfilter
Copy link

Appending to the result string now respects the read count.

Appending to the result string now respects the read count.
@johannish
Copy link
Collaborator

Would you be willing to add a unit test that demonstrates the issue?

Appending to the result string now respects the read count.
Fix for second code occurrence of clob transformation.
johannish added a commit that referenced this pull request Sep 17, 2014
fix(CLOB): clob values had wrong values
@johannish johannish merged commit 2afb3f2 into joeferner:master Sep 17, 2014
@johannish
Copy link
Collaborator

@realityfilter Please try this again from the current master and confirm that your issue is resolved. I'd like to have some feedback before we push to npm.

@realityfilter
Copy link
Author

I have used this fix to export live data from oracle. To be on the safe side I calculated md5 hashes on the oracle side with LOWER(RAWTOHEX(DBMS_CRYPTO.HASH(UTL_RAW.CAST_TO_RAW(text), 1))) and compared it withe the result from this driver. With this patch applied both hashes match.

I did this for CLOBs too. Only after applying patch from #160 I was able to successfully export CLOB data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants