Treat WorkflowExecutionAlreadyStartedError as non-transient error (ub…

…er#1812)

Setting the WorkflowIDReusePolicy to
'WorkflowIDReusePolicyAllowDuplicateFailedOnly' or
'WorkflowIDReusePolicyRejectDuplicate' results in
'WorkflowExecutionAlreadyStartedError' on StartWorkflowExecution or
SignalWithStartWorkflowExecution. Since this error is treated as
retryable error it results in frontend to keep on retrying the call
until timeout.

common/util.go

@@ -198,6 +198,8 @@ func IsServiceNonRetryableError(err error) bool {
 		return true
 	case *workflow.DomainNotActiveError:
 		return true
+	case *workflow.WorkflowExecutionAlreadyStartedError:
+		return true
 	case *workflow.CancellationAlreadyRequestedError:
 		return true
 	case *yarpcerrors.Status:

host/signalworkflow_test.go

@@ -22,6 +22,7 @@ package host
 
 import (
 	"bytes"
+	"context"
 	"encoding/binary"
 	"strconv"
 	"strings"
@@ -1421,23 +1422,26 @@ func (s *integrationSuite) TestSignalWithStartWorkflow_IDReusePolicy() {
 		Identity:                            common.StringPtr(identity),
 		WorkflowIdReusePolicy:               &wfIDReusePolicy,
 	}
-	resp, err := s.engine.SignalWithStartWorkflowExecution(createContext(), sRequest)
+	ctx, _ := context.WithTimeout(context.Background(), 5*time.Second)
+	resp, err := s.engine.SignalWithStartWorkflowExecution(ctx, sRequest)
 	s.Nil(resp)
 	s.Error(err)
 	errMsg := err.(*workflow.WorkflowExecutionAlreadyStartedError).GetMessage()
 	s.True(strings.Contains(errMsg, "reject duplicate workflow ID"))
 
 	// test policy WorkflowIdReusePolicyAllowDuplicateFailedOnly
 	wfIDReusePolicy = workflow.WorkflowIdReusePolicyAllowDuplicateFailedOnly
-	resp, err = s.engine.SignalWithStartWorkflowExecution(createContext(), sRequest)
+	ctx, _ = context.WithTimeout(context.Background(), 5*time.Second)
+	resp, err = s.engine.SignalWithStartWorkflowExecution(ctx, sRequest)
 	s.Nil(resp)
 	s.Error(err)
 	errMsg = err.(*workflow.WorkflowExecutionAlreadyStartedError).GetMessage()
 	s.True(strings.Contains(errMsg, "allow duplicate workflow ID if last run failed"))
 
 	// test policy WorkflowIdReusePolicyAllowDuplicate
 	wfIDReusePolicy = workflow.WorkflowIdReusePolicyAllowDuplicate
-	resp, err = s.engine.SignalWithStartWorkflowExecution(createContext(), sRequest)
+	ctx, _ = context.WithTimeout(context.Background(), 5*time.Second)
+	resp, err = s.engine.SignalWithStartWorkflowExecution(ctx, sRequest)
 	s.Nil(err)
 	s.NotEmpty(resp.GetRunId())