Skip to content

Fix function pointer disagreement#499

Merged
jobovy merged 1 commit intojobovy:mainfrom
hoodmane:fpcast
Aug 29, 2022
Merged

Fix function pointer disagreement#499
jobovy merged 1 commit intojobovy:mainfrom
hoodmane:fpcast

Conversation

@hoodmane
Copy link
Contributor

This fixes the error:

galpy/orbit/orbit_c_ext/integratePlanarOrbit.c:439:35: error: incompatible function pointer types assigning to 'double (*)(double, double, double, double, struct potentialArg *)' from 'double (*)(double, double, double, struct potentialArg *)' [-Wincompatible-function-pointer-types]
      potentialArgs->potentialEval= &ZeroPlanarForce;

https://app.circleci.com/pipelines/github/hoodmane/pyodide/3785/workflows/deda3693-7508-459d-a8e1-2f576f821532/jobs/45989

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #499 (3d71b3d) into main (de7da19) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         196      196           
  Lines       27353    27353           
=======================================
  Hits        27307    27307           
  Misses         46       46           
Impacted Files Coverage Δ
galpy/orbit/orbit_c_ext/integratePlanarOrbit.c 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jobovy jobovy merged commit eb89a7a into jobovy:main Aug 29, 2022
@jobovy
Copy link
Owner

jobovy commented Aug 29, 2022

Thanks for the fix! I guess this slipped through because regular C compilers don't error on this.

hoodmane added a commit to pyodide/pyodide that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants