chore(PRO-3057): cleanup & bump composer vendors #84
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,3 @@ | |
| /composer.symlink | ||
| composer.lock | ||
| .phpunit.result.cache | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,35 +17,36 @@ | |
| "rdkafka" | ||
| ], | ||
| "require": { | ||
| "php": "^8.1", | ||
| "ext-rdkafka": "^4.0|^5.0|^6.0" | ||
| }, | ||
| "require-dev": { | ||
| "ext-pcntl": "*", | ||
| "flix-tech/avro-serde-php": "^1.7.2 || ^2.2.0 || ^3.0.0", | ||
|
Comment on lines
+20
to
+25
Contributor
There was a problem hiding this comment. "flix-tech/avro-serde-php": "^1.7.2"can work only with php If problem you trying to solve is to use "flix-tech/avro-serde-php": "^1.7.2 || ^2.2.0 || ^3.0.0",rest can be reverted and we'll release patch version. The same applies for this PR
Member
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment. yup including 8.0. But one of change in this pr is to remove support for php versions below 8.1, which is not necessary, because it's a BC. In general, for releasing a new version we have to make a plan. So we should do everything we can to avoid introducing a BC
Member
Author
There was a problem hiding this comment.
Why? It's a jobcloud library, not used that much outside of our own projects, PHP 8.0 is not supported anymore, furthermore I actually plan to do a new major version, therefore I don't see any problems having small BC breaks then.
Contributor
There was a problem hiding this comment. This lib is not jobcloud exclusive. That's why we have jobcloud-kafka-lib. There is nothing wrong with introducing a new major version. What we don't want is to introduce new version often(every week, month etc...) Instead we wanna plan all things that should be part of next major release eg. changing an api or internals. For example, end support date for php 8.1 is December 31, 2025, meaning lowest supported version potentially should be 8.2. I'd suggest trying to solve without needing releasing major version. If this is not possible, than we should proceed with release candidate(RC) version
Member
Author
There was a problem hiding this comment. So what's your actual Change Request?
Contributor
There was a problem hiding this comment. preferably if it's possible only this "flix-tech/avro-serde-php": "^1.7.2 || ^2.2.0 || ^3.0.0",
Member
Author
There was a problem hiding this comment. Sorry, I don't get it, what shall I change from what to what? And I would be fine with a new major (but not sure why we need RCs).
Contributor
There was a problem hiding this comment.
The reason for releasing RC is so we can go further with development, even-thought there's still things we might include in next major release. RC allowing us to incrementally change code without frequent releasing major versions. Let's have call tomorrow, since I'm bit confused
Member
Author
There was a problem hiding this comment. OK, nevermind I think all this RC stuff is slowing us down. |
||
| "infection/infection": "^0.29.8", | ||
| "johnkary/phpunit-speedtrap": "^v3.3.0", | ||
| "kwn/php-rdkafka-stubs": "^v2.2.1", | ||
| "php-mock/php-mock-phpunit": "^2.13.0", | ||
| "phpstan/phpstan": "^2.1.24", | ||
| "phpunit/phpunit": "^9.6.26", | ||
| "rregeer/phpunit-coverage-check": "^0.3.1", | ||
| "squizlabs/php_codesniffer": "^3.13.4" | ||
| }, | ||
| "autoload": { | ||
| "psr-4": { | ||
| "Jobcloud\\Kafka\\": "src/" | ||
| } | ||
| }, | ||
| "autoload-dev": { | ||
| "psr-4": { | ||
| "Jobcloud\\Kafka\\Tests\\": "tests/" | ||
| } | ||
| }, | ||
| "suggest": { | ||
| "flix-tech/avro-serde-php": "Is needed for Avro support" | ||
| }, | ||
| "config": { | ||
| "sort-packages": true, | ||
| "allow-plugins": { | ||
| "infection/extension-installer": false | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| services: | ||
| php: | ||
| build: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| services: | ||
| php: | ||
| build: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,33 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| colors="true" | ||
| forceCoversAnnotation="true" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"> | ||
| <coverage> | ||
| <include> | ||
| <directory>src</directory> | ||
| </include> | ||
| <report> | ||
| <clover outputFile="build/logs/phpunit/clover.xml"/> | ||
| <html outputDirectory="build/logs/phpunit/coverage-html"/> | ||
| <text outputFile="php://stdout" showOnlySummary="true"/> | ||
| <xml outputDirectory="build/logs/phpunit/coverage-xml"/> | ||
| </report> | ||
| </coverage> | ||
| <php> | ||
| <ini name="max_execution_time" value="-1"/> | ||
| <ini name="html_errors" value="false"/> | ||
| <ini name="memory_limit" value="-1"/> | ||
| </php> | ||
| <testsuites> | ||
| <testsuite name="Unit"> | ||
| <directory>./tests/Unit</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
| <logging> | ||
| <junit outputFile="build/logs/phpunit/junit.xml"/> | ||
| </logging> | ||
| <listeners> | ||
| <listener class="JohnKary\PHPUnit\Listener\SpeedTrapListener"/> | ||
| </listeners> | ||
| </phpunit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an archived project, the download of this file does not even exist anymore.