chore(deps): update zip 7.0, plotly 0.14, positive 0.3 #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update zip from 6.0 to 7.0 - Update plotly from 0.13 to 0.14 - Update positive from 0.2.1 to 0.3 Leverage new Positive constants and methods: - Replace pos_or_panic!(30.0) with Positive::THIRTY - Replace pos_or_panic!(5.0) with Positive::FIVE - Replace pos_or_panic!(0.01) with Positive::new(0.01).expect() - Replace pos_or_panic!(0.2) with Positive::new(0.2).expect() - Update mean_and_std() to use Positive::new().unwrap_or() - Remove unused pos_or_panic import from production code - Add pos_or_panic import to test modules where needed Closes #257
joaquinbejar
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
…-zip-plotly-positive # Conflicts: # src/model/utils.rs
- Update test modules in `utils.rs` to include `pos_or_panic` from `positive` crate. - Ensure consistency across test imports.
- Create `intrinsic_value_chart.html` with Plotly visualization of intrinsic value. - Include corresponding `intrinsic_value_chart.png` for static representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update dependencies to their latest versions and leverage new features from positive 0.3.
Dependency Updates
zipplotlypositiveChanges
Cargo.toml
src/model/utils.rs
pos_or_panic!(30.0)withPositive::THIRTYpos_or_panic!(5.0)withPositive::FIVEpos_or_panic!(0.01)withPositive::new(0.01).expect()pos_or_panic!(0.2)withPositive::new(0.2).expect()mean_and_std()to usePositive::new().unwrap_or()pos_or_panicimport from production codepos_or_panicimport to test modules where neededTesting
cargo build- Compiles successfullycargo test --lib- All 3631 tests passmake lint-fix- No warningsmake pre-push- All checks passRelated Issue
Closes #257