Feature/positive f64 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced u32 with PositiveF64 for option quantity to ensure positive float values throughout the pricing and strategies modules. Updated related unit tests and visualization components to use the new type properly, enhancing the accuracy and flexibility in representing quantities.
Converted quantities in various strategy examples to use the PositiveF64 type with the pos! macro for consistency and type safety. This change enhances the clarity and correctness of the quantity parameters across different option strategy implementations.
This commit introduces comprehensive unit tests for the PositiveF64 struct to ensure its functionality. These tests cover creation, addition, division, multiplication, equality, display, and formatting behaviors. Essential constants and a macro for generating PositiveF64 instances are also tested.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
This was referenced Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change quantity type to PositiveF64
Replaced u32 with PositiveF64 for option quantity to ensure positive float values throughout the pricing and strategies modules. Updated related unit tests and visualization components to use the new type properly, enhancing the accuracy and flexibility in representing quantities.