Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex completion style is not available on Emacs < 27 #582

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

juergenhoetzel
Copy link
Contributor

  • eglot.el (eglot--managed-mode): safety check for available flex style

Fixes this issue on Emacs 26.3:

Debugger entered--Lisp error: (void-function nil)
  nil("" #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil 0)
  #f(compiled-function (style) #<bytecode 0x1463319>)(flex)
  completion--some(#f(compiled-function (style) #<bytecode 0x1463319>) (flex basic))
  completion--nth-completion(1 "" #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil 0 (metadata (display-sort-function . #f(compiled-function (completions) #<bytecode 0x1174711>))))
  completion-try-completion("" #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil 0 (metadata (display-sort-function . #f(compiled-function (completions) #<bytecode 0x1174711>))))
  completion--do-completion(#<marker at 86 in Program.fs\Test1\test\emacs-fsharp-mode\fsharp\github\juergen\home\> 86)
  completion--in-region-1(#<marker at 86 in Program.fs\Test1\test\emacs-fsharp-mode\fsharp\github\juergen\home\> 86)
  #f(compiled-function (start end collection predicate) #<bytecode 0x1cb03f>)(#<marker at 86 in Program.fs\Test1\test\emacs-fsharp-mode\fsharp\github\juergen\home\> 86 #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil)
  apply(#f(compiled-function (start end collection predicate) #<bytecode 0x1cb03f>) (#<marker at 86 in Program.fs\Test1\test\emacs-fsharp-mode\fsharp\github\juergen\home\> 86 #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil))
  #f(compiled-function (funs global args) #<bytecode 0x14632f1>)(nil nil (#<marker at 86 in Program.fs\Test1\test\emacs-fsharp-mode\fsharp\github\juergen\home\> 86 #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil))
  completion--in-region(#<marker at 86 in Program.fs\Test1\test\emacs-fsharp-mode\fsharp\github\juergen\home\> 86 #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil)
  completion-in-region(#<marker at 86 in Program.fs\Test1\test\emacs-fsharp-mode\fsharp\github\juergen\home\> 86 #f(compiled-function (probe pred action) #<bytecode 0x1462fbd>) nil)
  completion-at-point()
  eval((completion-at-point) nil)
  eval-expression((completion-at-point) nil nil 127)
  funcall-interactively(eval-expression (completion-at-point) nil nil 127)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)

* eglot.el (eglot--managed-mode): safety check for available flex style
@joaotavora joaotavora merged commit 16bbf85 into joaotavora:master Jan 5, 2021
@joaotavora
Copy link
Owner

Thanks very much!

bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 18, 2022
…macs < 27

* eglot.el (eglot--managed-mode): check if flex style available 

Copyright-paperwork-exempt: yes
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 19, 2022
…macs < 27

* eglot.el (eglot--managed-mode): check if flex style available 

Copyright-paperwork-exempt: yes
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 19, 2022
* eglot.el (eglot--managed-mode): check if flex style available 

Copyright-paperwork-exempt: yes
#582: joaotavora/eglot#582
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Oct 12, 2022
* eglot.el (eglot--managed-mode): check if flex style available 

Copyright-paperwork-exempt: yes
GitHub-reference: fix joaotavora/eglot#582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants