-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #277: Send exit as a notification #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Ok. But let's just be aware that this is changing the timings for a shutdown. It shouldn't make any difference, but the line below will probably not "return immediately" anymore. It is now jsonrpc-notify
that returns immediately (but there's no need to write that fact).
So maybe just delete the comment on parenthesis. Also let's keep @ilohmar in the loop if he isn't yet.
Thanks for mentioning me. I cannot see anything wrong with the change, but as I said elsewhere, I have never dug deeply into jsonrpc at all. |
I recently double-checked that |
This is what the specification requires. @PerMildner, thanks for reporting and analyzing the issue. * eglot.el (eglot-shutdown): Use `notify' instead of `request' for the `exit' LSP method.
c83a8cd
to
9c52f24
Compare
…77-exit-notification Fix joaotavora/eglot#277: Send exit as a notification
…77-exit-notification Fix joaotavora/eglot#277: Send exit as a notification
…tion Fix #277: Send exit as a notification #400: joaotavora/eglot#400 #277: joaotavora/eglot#277
Fix joaotavora/eglot#277: Send exit as a notification GitHub-reference: joaotavora/eglot#400
This is what the specification requires. @PerMildner, thanks for
reporting and analyzing the issue.
notify
instead ofrequest
for theexit
LSP method.