Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #277: Send exit as a notification #400

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

nemethf
Copy link
Collaborator

@nemethf nemethf commented Jan 4, 2020

This is what the specification requires. @PerMildner, thanks for
reporting and analyzing the issue.

  • eglot.el (eglot-shutdown): Use notify instead of request for the
    exit LSP method.

Copy link
Owner

@joaotavora joaotavora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Ok. But let's just be aware that this is changing the timings for a shutdown. It shouldn't make any difference, but the line below will probably not "return immediately" anymore. It is now jsonrpc-notify that returns immediately (but there's no need to write that fact).

So maybe just delete the comment on parenthesis. Also let's keep @ilohmar in the loop if he isn't yet.

@ilohmar
Copy link
Collaborator

ilohmar commented Jan 5, 2020

Thanks for mentioning me. I cannot see anything wrong with the change, but as I said elsewhere, I have never dug deeply into jsonrpc at all.

@joaotavora
Copy link
Owner

I have never dug deeply into jsonrpc at all.

I recently double-checked that jsonrpc-shutdown doesn't exit with a live process. (I think at least, I put a lot of effort into making it so). So I think we should be fine. @nemethf do the change and push at will.

This is what the specification requires.  @PerMildner, thanks for
reporting and analyzing the issue.

* eglot.el (eglot-shutdown): Use `notify' instead of `request' for the
`exit' LSP method.
@nemethf nemethf force-pushed the scratch/fix-277-exit-notification branch from c83a8cd to 9c52f24 Compare January 5, 2020 13:29
@nemethf nemethf merged commit a4c83a6 into master Jan 5, 2020
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 18, 2022
…77-exit-notification

Fix joaotavora/eglot#277: Send exit as a notification
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 19, 2022
…77-exit-notification

Fix joaotavora/eglot#277: Send exit as a notification
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 19, 2022
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants