Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textDocument/didChange has incorrect syncKind #86

Closed
zainab-ali opened this issue Aug 25, 2018 · 2 comments
Closed

textDocument/didChange has incorrect syncKind #86

zainab-ali opened this issue Aug 25, 2018 · 2 comments

Comments

@zainab-ali
Copy link

In eglot--signal-textDocument/didChange, the following line:

(sync-kind (eglot--server-capable :textDocumentSync))

should be

(sync-kind (eglot--server-capable :textDocumentSync :change))

Without this, we never handle the case of full sync and always send incremental updates.
@zainab-ali zainab-ali mentioned this issue Aug 25, 2018
Closed
zainab-ali added a commit to zainab-ali/eglot that referenced this issue Aug 25, 2018
@zainab-ali
Close joaotavora#86: Correctly assign syncKind in testDocument/didChange
9eaec13
@joaotavora
Copy link
Owner

Hi. Thanks for the report.

Without this, we never handle the case of full sync and always send incremental updates.

No. That only happens if the server is sending a TextDocumentSyncOptions structure in the value of :textDocumentSync. Most are sending just a number.

The commit I pushed handles both cases.

@zainab-ali
Copy link
Author

Thanks!

bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 18, 2022
@joaotavora
Close joaotavora/eglot#86: Handle case when :textDocumentSync isn't a…
62c5947 
… number

Also closes joaotavora/eglot#87.

* eglot.el (eglot--signal-textDocument/didChange): Grab :change
from :textDocumentSync server capability.
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@joaotavora
Close joaotavora/eglot#86: Handle case when :textDocumentSync isn't a…
0eeb7a2 
… number

Also closes joaotavora/eglot#87.

* eglot.el (eglot--signal-textDocument/didChange): Grab :change
from :textDocumentSync server capability.
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@joaotavora
Close #86: Handle case when :textDocumentSync isn't a number
93bea5c 
Also closes #87.

* eglot.el (eglot--signal-textDocument/didChange): Grab :change
from :textDocumentSync server capability.

#86: joaotavora/eglot#86
#87: joaotavora/eglot#87
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this issue Oct 12, 2022
@joaotavora
Handle case when :textdocumentsync isn't a number
d01b511 
Also closes joaotavora/eglot#87.

* eglot.el (eglot--signal-textDocument/didChange): Grab :change
from :textDocumentSync server capability.

GitHub-reference: close joaotavora/eglot#86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaotavora @zainab-ali