Repository navigation
fix(install): reorder the tunnel questions, drop second-account support, default auto-update to yes - #16
Merged
Conversation
- Ask the tunnel provider BEFORE the ngrok domain, in the interactive flow and in emit_questions: the domain is ngrok-only, so it should not be asked before the user has chosen a provider. A domain already stored is carried through unchanged when tunnl is chosen, so switching back cannot lose it. - Remove the second-account / multi-account feature entirely: the prompt, the plan key, the plumbing, the generated output, the registry field, the tests and the docs. A leftover "accounts" key in an old og-install.json (or a hand-written plan) is ignored rather than refused. - Always default the auto-update prompt to yes, so pressing Enter means on regardless of a previously saved "no"; only an explicit "n" turns it off. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Restore the surviving half of the orchestrator config comment removed with the second-account feature: claude-native is the real Claude Code CLI, so it inherits settings.json (and shell hooks) and can be opened or taken over in a real terminal. The CLAUDE_CONFIG_DIR / second-account clause stays deleted. The comment sits in executor.config, outside the prompt string, so the shell-quoted prompt size is unchanged (8665 for the reference lineup, identical to main). Tests: - assert the tunnl path does NOT prompt for an ngrok domain at all. - widen test_no_account_wiring_survives_anywhere to scan the installer source and bin/og for the feature terms (docs deliberately excluded). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to the setup flow.
1. The tunnel provider is asked before the ngrok domain
build_plan_interactiveasked for a reserved ngrok domain before asking which tunnel provider to use, so users answered an ngrok-only question before saying whether they wanted ngrok. The order is now provider → ngrok domain → tunnl SSH key, and the domain is skipped entirely when the provider istunnl. A storedngrok_domainis carried through unchanged on the tunnl path, so switching to tunnl and back does not lose a reserved domain.emit_questions()emits the same new order, since an AI driving--questionsasks them as emitted. This also makes the code matchREADME.md, which already documented provider-first.2. The second-Claude-account feature is removed
Removed in full: the interactive question, the
accountsplan key,account_entries(),account_note(), the{{ACCOUNT_NOTE}}placeholder in the reviewer/scout/integrator templates, thevalidate()shared-env check, thewrite_og_envOG_<env>=loop, theemit_questionsaccountsquestion, theshow()account line,multi_accountinregistry.json, theOG_CLAUDE_CONFIG_DIR→CLAUDE_CONFIG_DIRexport and itsOMNIGENT_RUNNER_ENV_PASSTHROUGHentry inbin/og, theaccount: ...diagnostic, and the prose in AGENTS.md, README.md, docs/ARCHITECTURE.md and docs/TROUBLESHOOTING.md.The foreground-host / env-passthrough machinery in
bin/ogserves more than this feature, so it is kept with only the account-specific clauses stripped — theOPENCODE_*passthrough is intact.Backward compatible: an existing
~/.omnigent/og-install.jsonholding"accounts": {...}still installs. The key is ignored rather than refused, and is round-tripped inert rather than stripped, so a downgrade stays safe.3. Auto-update always defaults to yes
The default came from saved state, so a user who once answered
nsaw(y/N)on every later re-run. It is now a literalTrue: the prompt always renders(Y/n), Enter means yes, and only an explicitnturns it off.Verification
bash -nandshellcheck -S errorclean onbin/ogandinstall.sh.~/.omnigent) exits 0 on a clean plan, on a legacy plan carrying a staleaccountskey, and on a rerun over the same sandbox. All 7 generated YAML files parse.CLAUDE_CONFIG_DIR,OG_CLAUDE_CONFIG_DIR,ACCOUNT_NOTEormulti_account.Noneis the registry-sanctioned unpinned codex reviewer.main.Six tests added, including a guard that no account wiring survives in
installer/og_install.pyorbin/og, and an interactive test proving the ngrok-domain prompt is absent undertunnlrather than merely defaulted.cross-vendor-review: passed
Implemented by a deepseek worker, reviewed independently by an OpenAI reviewer. The review raised one blocking issue — a restored
claude-nativerationale comment inorchestrator.yaml.tmplwhose non-account content was still relevant — which is fixed in3265646, plus two test-coverage suggestions that were adopted. Re-review returned no blocking issues.🤖 Generated with Claude Code