Skip to content

Replace bindArgs to bindAnyArgs to support map #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Replace bindArgs to bindAnyArgs to support map #616

merged 1 commit into from
Jun 13, 2020

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented May 5, 2020

By #285 , batch insert is supported.
But currently, it is failed to insert the list of map because bindArgs doesn't support map.
So replace bindArgs to bindAnyArgs in bindArray.


The other pull request to fix this bug already exists #501 but I create a new pull request in two reasons.

  1. add support for batch insert/exec with maps in addition to structs #501 isn't updated for over one year.
  2. In add support for batch insert/exec with maps in addition to structs #501 bindArgs is fixed but we don't have to fix bindArgs. To accept both of map and struct, we should use bindAnyArgs.

@coveralls
Copy link

coveralls commented May 5, 2020

Pull Request Test Coverage Report for Build 141

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.751%

Totals Coverage Status
Change from base Build 137: 0.0%
Covered Lines: 1000
Relevant Lines: 1476

💛 - Coveralls

@jmoiron jmoiron merged commit 53323b7 into jmoiron:master Jun 13, 2020
@suzuki-shunsuke suzuki-shunsuke deleted the fix/support-bulk-insert-of-map branch June 30, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants