Can not seem to use Float read or write functionality

[gman8a]

code

const { Layers } = require('node-drivers');
const tcpLayer = new Layers.TCP({ host: '192.168.0.230', port: 44818 });
const eipLayer = new Layers.EIP(tcpLayer);
const cipPCCCLayer = new Layers.CIP.PCCC(eipLayer);
const pccc = new Layers.PCCC(cipPCCCLayer);

pccc.typedWrite('F8:1', 0, (err)=> { if (err)console.log(err);})
pccc.typedRead( 'F8:1', (err, value)=> {
if (err)
console.log(err);
else console.log(value);
})

return this
$ node test1.js
{ message: 'Invalid parameter or invalid data',
info:
PCCCPacket {
command: 79,
transaction: 1,
data: ,
status:
{ code: 240,
extended: [Object],
description: 'Remote: Error code in the EXT STS byte' } } }
2.2779507836064226e-41

Note:
F8:1 has a value 1.00000
F8:2 has a value 2.00000

Any help please ?
Thanks,
Gary

---

[jmmoser]

@gman8a Thanks for trying out node-drivers! Can you share extended error? Console.log is abbreviating it to [Obect] in your post. Please run it again and log this: console.log(err.info.status)

[gman8a]

$ node test1.js
REPLY:
code

pccc.typedWrite('F8:1', 0, (err)=> {
if (err) {
console.log(err.info);
//console.log(err.info.status)
}
})

---

results

PCCCPacket {
command: 79,
transaction: 1,
data: ,
status:
{ code: 240,
extended: { code: 18, description: 'Invalid parameter or invalid data' },
description: 'Remote: Error code in the EXT STS byte' } }
2.2779507836064226e-41
^C

[gman8a]

Hi Justin, anything obvious? anything I can do to help? Gary

…

On Mon, Nov 25, 2019 at 6:06 PM Justin Moser ***@***.***> wrote: @gman8a <https://github.com/gman8a> Thanks for trying out node-drivers! Can you share extended error? Console.log is abbreviating it to [Obect] in your post. Please run it again and log this: console.log(err.info.status) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AGNHFF5MCTBVOJ7QQN6IW5DQVRK6NA5CNFSM4JRP4IEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEDRMI#issuecomment-558381233>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGNHFF7WNNONQ7IVER3AY43QVRK6NANCNFSM4JRP4IEA> .

[jmmoser]

@gman8a Sorry for the late response! I just got back to the computer. I'm going to read through the DF1 reference manual again just to make sure I'm doing this properly. I'm also going to try reading from the PLC-5 device I have access to.

[jmmoser]

@gman8a I just tried on the device I have access to and it worked as expected. What kind of PLC are you trying to read from? I'm wondering if your device supports the typed read command. PLC-5, PLC-5/VME, SLC 5/03, and SLC 5/04 support typed read according to the manual. Have you tried using typedRead() to read a different data type (e.g. N10:47)?

[jmmoser]

@gman8a Disregard everything I have said so far! I didn't realize it was the typedWrite that was failing, not the typedRead. Let me dig into this again!

[gman8a]

both are failing the read has a goofy value Gary

…

On Mon, Nov 25, 2019 at 7:46 PM Justin Moser ***@***.***> wrote: @gman8a <https://github.com/gman8a> Disregard everything I have said so far! I didn't realize it was the typedWrite that was failing, not the typedRead. Let me dig into this again! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AGNHFF2GGBUA4BX5BTUF6OLQVRWU7A5CNFSM4JRP4IEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEJ6KY#issuecomment-558407467>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGNHFF33VMH3WOWK47PBCSLQVRWU7ANCNFSM4JRP4IEA> .

[gman8a]

Justin, typedRead of integers works fine typedWrite of integers also works fine; however, both float R/W are whacked. let me know what i can do to help Gary On Mon, Nov 25, 2019 at 8:02 PM Gary Argraves <garyargraves@gmail.com> wrote:

…

both are failing the read has a goofy value Gary On Mon, Nov 25, 2019 at 7:46 PM Justin Moser ***@***.***> wrote: > @gman8a <https://github.com/gman8a> Disregard everything I have said so > far! I didn't realize it was the typedWrite that was failing, not the > typedRead. Let me dig into this again! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#2?email_source=notifications&email_token=AGNHFF2GGBUA4BX5BTUF6OLQVRWU7A5CNFSM4JRP4IEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEJ6KY#issuecomment-558407467>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AGNHFF33VMH3WOWK47PBCSLQVRWU7ANCNFSM4JRP4IEA> > . >

[jmmoser]

@gman8a I think I found the issue. I'm not encoding the type/data parameter correctly for the write request. I'll publish an updated version to npm as soon as possible. Thank you for pointing this out.

[gman8a]

Justin, excellent Please test Float reads too. I think they be bd; when i write a value using another LLD/ driver, and read back with yours, get wacky value. Gary

…

On Wed, Nov 27, 2019 at 4:19 PM Justin Moser ***@***.***> wrote: @gman8a <https://github.com/gman8a> I think I found the issue. I'm not encoding the type/data parameter correctly for the write request. I'll publish an updated version to npm as soon as possible. Thank you for pointing this out. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AGNHFFZJPXSYITXTP5IBGNLQV3P6LA5CNFSM4JRP4IEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFKYW6A#issuecomment-559254392>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGNHFFYX7ZS7RW7K2XY4Y5TQV3P6LANCNFSM4JRP4IEA> .

[gman8a]

Also do you have a feel for re-connection ability of your driver if i unplug the cable, the highest layer does not see and connect errors; so can not rip down the conn. and start over with anew. Gary On Thu, Nov 28, 2019 at 6:19 PM Gary Argraves <garyargraves@gmail.com> wrote:

…

Justin, excellent Please test Float reads too. I think they be bd; when i write a value using another LLD/ driver, and read back with yours, get wacky value. Gary On Wed, Nov 27, 2019 at 4:19 PM Justin Moser ***@***.***> wrote: > @gman8a <https://github.com/gman8a> I think I found the issue. I'm not > encoding the type/data parameter correctly for the write request. I'll > publish an updated version to npm as soon as possible. Thank you for > pointing this out. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#2?email_source=notifications&email_token=AGNHFFZJPXSYITXTP5IBGNLQV3P6LA5CNFSM4JRP4IEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFKYW6A#issuecomment-559254392>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AGNHFFYX7ZS7RW7K2XY4Y5TQV3P6LANCNFSM4JRP4IEA> > . >

[jmmoser]

@gman8a I know I’ve read floats before and received values I expected but I’ll take another look at that section of the code. Without writing any values, what value do you receive when you read F8:1 with node-drivers and what value do you receive when you read F8:1 with the other driver?

All layers in node-drivers (should) handle connecting and reconnecting for you. However, since you asked I just realized the TCP layer does not handle reconnecting currently. This will be very simple to add.

[gman8a]

// Other driver ~/wic/ccs$ ./rw_plc5 read_F 8 1 F8:1=1.000003 // WRITE ======================= ~/wic/ccs$ node test1.js PCCCPacket { command: 79, transaction: 1, data: <Buffer >, status: { code: 240, extended: { code: 18, description: 'Invalid parameter or invalid data' }, description: 'Remote: Error code in the EXT STS byte' } } ^C READ ================ ~/wic/ccs$ node test1.js -190570791299973120

…

On Thu, Nov 28, 2019 at 6:59 PM Justin Moser ***@***.***> wrote: @gman8a <https://github.com/gman8a> I know I’ve read floats before and received values I expected but I’ll take another look at that section of the code. Without writing any values, what value do you receive when you read F8:1 with node-drivers and what value do you receive when you read F8:1 with the other driver? All layers in node-drivers (*should*) handle connecting and reconnecting for you. However, since you asked I just realized the TCP layer does not handle reconnecting currently. This will be very simple to add. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AGNHFF643PF4DQYTDH337KLQWBLPVA5CNFSM4JRP4IEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNSJ3A#issuecomment-559621356>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGNHFF6MC3Z3NOZZXYN2PHDQWBLPVANCNFSM4JRP4IEA> .

[jmmoser]

@gman8a I just published a new pre-release to npm that includes updates to the PCCC type/data parameter encoding and the TCP layer automatic reconnect feature. You can upgrade to this release with npm i --save node-drivers@beta. Please let me know if this fixes the issue!

[gman8a]

Hi Justin, Got this error : $ node test1.js /mnt/WIC/node_modules/node-drivers/src/layers/tcp/TCPLayer.js:31 static async* Scan(hosts, ports) { ^ SyntaxError: Unexpected token * at createScript (vm.js:80:10) at Object.runInThisContext (vm.js:139:10) at Module._compile (module.js:616:28) at Object.Module._extensions..js (module.js:663:10) at Module.load (module.js:565:32) at tryModuleLoad (module.js:505:12) at Function.Module._load (module.js:497:3) at Module.require (module.js:596:17) at require (internal/module.js:11:18) at Object.<anonymous> (/mnt/WIC/node_modules/node-drivers/src/index.js:5:10)

…

On Fri, Dec 6, 2019 at 11:36 PM Justin Moser ***@***.***> wrote: @gman8a <https://github.com/gman8a> I just published a new pre-release to npm that includes updates to the PCCC type/data parameter encoding. You can upgrade to this release with npm i --save ***@***.*** Please let me know if this fixes the issue! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AGNHFFZUEC5D7QX4BF5JN3DQXMR5RA5CNFSM4JRP4IEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGF5T6I#issuecomment-562813433>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGNHFF2BX4RZMJ37OR6NEL3QXMR5RANCNFSM4JRP4IEA> .