Test with Ruby 3.2 and 3.3 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making a contribution, it's useful to know how to run the test suite. Usually I would expect `rake` or `rake test` to work, but this project has no Rakefile, so I think it's fine to simply document how to run the test suite: `rspec spec`
I believe this _should just work_ but I guess GitHub Actions CI will have the last word : )
|
I had to push f7c89aa because Ruby 2.5 and below won't work with ARM in GitHub Actions CI. |
|
Hey @etagwerker thanks! Since this is test only, I'll hold off on releasing a new gem version for the moment, but this is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jmmastey Hi there 👋🏼
I thought it could be useful to test the gem with Ruby 3.2 and 3.3.
Also, while working on this I had to figure out (again) how to run the test suite so I added a short snippet about this to the README.
Please let me know if you have any questions.
Thanks!