Add Auto-Instrumentation for distributed tracing #5058
+556
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation-for-distributed-tracing-in-flow-ui
fractal3000
reviewed
Feb 6, 2026
| fireEvent(new ReadyEvent(this)); | ||
| getUiObservationSupport().createViewEventObservation(this, ReadyEvent.class.getSimpleName()) | ||
| .observe(() -> fireEvent(new ReadyEvent(this))); | ||
| stopViewTimerSample(sample, meterRegistry, READY, getId().orElse(null)); |
Contributor
There was a problem hiding this comment.
Why do we need to use Timer and Observation at the same time? As I know, Observation contains Timer functions inside.
|
|
||
| @SuppressWarnings("unchecked") | ||
| E entity = (E) storage.load(context); | ||
| E entity = (E) observationSupport.createEntityLoadObservation(metaClass, context.getQuery()) |
Contributor
There was a problem hiding this comment.
Can we use it not only in the DataManager, but also in the DataLoader(s) (when we currently use Timers)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom spans for the following cases:
Implemented observation context propagation for background tasks.
The following application properties have been added:
jmix.core.data-observation-enabledwithfalsedefault valuejmix.ui.ui-observation-enabledwithfalsedefault valueThe value of the properties controls the creation of custom spans in the application.
observability-test.zip