Remove realtime changing of reverb decay

The Oboe audio framework that used by Love2D on Android seems to have issues with reverb control. With decay change the instruments exhibit an unpleasant popping sound, most noticeable on bass instruments.
jmiskovic · Sep 6, 2024 · 3f50722 · 3f50722
1 parent 9c49325
commit 3f50722
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 7 deletions.
diff --git a/patches/broom/broom.lua b/patches/broom/broom.lua
@@ -43,7 +43,6 @@ end
 
 function patch:process(s)
   self.layout:interpret(s)
-  self.efx.reverb.decaytime = l.remap(s.tilt.lp[2], 0.7, -0.1, 0.2, 2.0, 'clamp')
   self.sampler.envelope.release = l.remap(s.tilt[2], .0, -0.2, 0.05, 5, 'clamp') -- sustain pedal
   self.efx:process()
   self.sampler:processTouches(s.dt, s.touches, self.efx)

diff --git a/patches/choir/choir.lua b/patches/choir/choir.lua
@@ -45,7 +45,6 @@ end
 
 function patch:process(s)
   self.layout:interpret(s)
-  self.efx.reverb.decaytime = l.remap(s.tilt.lp[2], 1, -1, 0.5, 10)
   self.sampler.envelope.attack  = 0.05 + math.abs(s.tilt.lp[1])
   self.sampler.envelope.release = 0.35 + math.abs(s.tilt.lp[1]) / 2
   self.efx:process()

diff --git a/patches/electrobeats/electrobeats.lua b/patches/electrobeats/electrobeats.lua
@@ -114,7 +114,6 @@ end
 
 function patch:process(s)
   self.layout:interpret(s)
-  self.efx.reverb.decaytime = l.remap(s.tilt.lp[1], 0.1, -0.5, 0.5, 4)
   self.efx:process()
   self.sampler:processTouches(s.dt, s.touches, self.efx)
   return s

diff --git a/patches/fretless/fretless.lua b/patches/fretless/fretless.lua
@@ -48,7 +48,6 @@ end
 
 function patch:process(s)
   self.layout:interpret(s)
-  self.efx.reverb.decaytime = l.remap(s.tilt.lp[2], -.1, 2, 0.5, 2)
   self.efx:process()
   self.sampler:processTouches(s.dt, s.touches, self.efx)
 end

diff --git a/patches/garage/garage.lua b/patches/garage/garage.lua
@@ -47,7 +47,6 @@ end
 
 function patch:process(s)
   self.layout:interpret(s)
-  self.efx.reverb.decaytime = l.remap(s.tilt.lp[1], 0.1, -0.5, 0.5, 4)
   self.efx:process()
   self.sampler:processTouches(s.dt, s.touches, self.efx)
   return s

diff --git a/patches/scat/scat.lua b/patches/scat/scat.lua
@@ -63,7 +63,6 @@ function patch:process(s)
     touch.velocity = l.remap(s.tilt[1], -0.2, 0.2, 0.1, 0.9, 'clamp')
   end
   self.layout:interpret(s)
-  self.efx.reverb.decaytime = l.remap(s.tilt.lp[2], 1, -1, 1, 5)
   self.efx:process()
   self.sampler:processTouches(s.dt, s.touches, self.efx)
 end

diff --git a/patches/strings/strings.lua b/patches/strings/strings.lua
@@ -68,7 +68,6 @@ function patch:process(s)
   self.tremolo.envelope.attack  = l.remap(s.tilt.lp[2], 0.0, -0.9, 0.0, 10, 'clamp')
   self.cello.envelope.release   = l.remap(s.tilt.lp[2], -0.05, -0.2, 0.6, 4, 'clamp')
   self.tremolo.envelope.release = l.remap(s.tilt.lp[2], -0.05, -0.2, 0.5, 2, 'clamp')
-  self.efx.reverb.decaytime     = l.remap(s.tilt.lp[2], 0.0, -0.9, 1.0, 8.0, 'clamp')
   -- crossfade between instruments
   self.cello.masterVolume   = l.remap(s.tilt.lp[1], -0.2, 0.3, 1, 0.2, 'clamp')
   self.tremolo.masterVolume = l.remap(s.tilt.lp[1], -0.1, 0.4, 0.2, 1, 'clamp')