Synchronize with internal (partially) #126
Conversation
tamird
commented
Mar 24, 2025
tamird
commented
- Remove update checker
- Disable default-features for all dependencies
- Enable clippy::unused_trait_names
- Add dependabot config
- Split default config into its own file
- .github: run on all branches
- Add mac,windows to CI
This crate doesn't receive timely releases, this is a pointless feature that has been removed in the internal Meta fork.
All except clap; default features include usage which we want.
CI is cheap; this is better for forks.
tamird
force-pushed
the
internal-stuff
branch
2 times, most recently
from
54fbb07 to
5815e9e
Compare
It reduces completion times for unneeded features. |
I don't think that's worth doing, given that a clean build takes like 15 seconds on my machine. |
|
Why wouldn't you want to be explicit? If a feature is needed, we should enable it explicitly. |
|
Because that's the entire point of defaults? I don't think it's worth anything to force ourselves to specify |
|
There are two new |
If my count is right, you're changing 25 crate imports, over half of which do nothing because they don't actually have default features specified, two of which either change behavior or possibly break things (clap losing cargo to fetch data from crate properties, regex losing unicode), and pretty much everything else being just |
|
I don't remember now, but I feel like the clap:cargo removal was intentional. Anyway, if you want to take this without that commit, you can. |
|
Manually merged, skipping the first two commits |
|
We really need to remove the update checker; it's pointless if you're not making releases, and inherently incompatible with internal usage. At least, we should put it behind a feature. |
