Added option to disable runtime exceptions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2015 11:19
This adds a way to disable all errors during the .visit(object) stage. Parse errors will still be raised, but runtime exceptions such as values being of the wrong type for a function will be ignored. Benchmarks show a 40% speedup in MRI and 500% in JRuby.
…ignorable visit exception
|
Sorry for the slow turn-around on this. I had a change to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the option
disable_visit_errors, which disables the raising of errors during runtime. Parse errors will still be raised, but all exceptions duringNode.visit(object)are disabled andnilis returned instead.We process very large amounts of data and sometimes objects do not have quite the right properties. So we have to catch
InvalidArityErrorandInvalidTypeErrorsince there is no way to preemptively check for these errors. This has quite a large overhead, especially in JRuby.I did some benchmarks with objects that always result in an exception, and this branch had a 40% speed increase in MRI, and a 500% increase in JRuby.
When not raising errors, there's no measurable difference between this branch and master, and also no difference between
disable_visit_errorsbeing off or on.