Skip to content

Fix SyntaxErrorException throwing ValueError in PHP 8 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GrahamCampbell merged 2 commits into from
Jun 14, 2021
Merged

Fix SyntaxErrorException throwing ValueError in PHP 8 #72

GrahamCampbell merged 2 commits into from
Jun 14, 2021

Conversation

@flavioheleno
Copy link
Contributor

@flavioheleno flavioheleno commented Jun 12, 2021

This PR fixes #71 by ensuring that $times parameter of str_repeat is always positive.

@GrahamCampbell GrahamCampbell merged commit 9b87907 into jmespath:master Jun 14, 2021
@GrahamCampbell
Copy link
Collaborator

GrahamCampbell commented Jun 14, 2021

Thanks. :)

@flavioheleno flavioheleno deleted the fix/value-error branch June 14, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edge Case: SyntaxErrorException throws ValueError in PHP 8

2 participants

@flavioheleno @GrahamCampbell