Skip to content

Commit

Permalink
Make pullapprove NOT always add 57 reviewers to every PR. (project-ch…
Browse files Browse the repository at this point in the history
…ip#35845)

* Make pullapprove NOT always add 57 reviewers to every PR.

Added CODEOWNERS for platforms, so that platform changes
are visible to relevant persons.

* Fix up codeowners

* Move codeowners to an obvious top visible name

* Use full paths for owners

* Fix names

* Fix group names: shared is a concept in pullapprove

* Try to see if owner name without at is ok

* Undo at syntax

* Align paths a bit better

* Add some file types to codeowners

* Docker image paths

* Update CODEOWNERS

Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com>

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com>
  • Loading branch information
3 people authored Sep 30, 2024
1 parent ba7c3e0 commit fa0b299
Show file tree
Hide file tree
Showing 3 changed files with 90 additions and 21 deletions.
2 changes: 0 additions & 2 deletions .github/CODEOWNERS

This file was deleted.

38 changes: 19 additions & 19 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,79 +84,79 @@ groups:
reviewers:
teams: [reviewers-amazon]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-apple:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-apple]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-bosch:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-bosch]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-comcast:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-comcast]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-dyson:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-dyson]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-espressif:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-espressif]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-google:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-google]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-grundfos:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-grundfos]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-irobot:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-irobot]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-lg:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-lg]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-logitech:
type: optional
conditions:
Expand All @@ -172,31 +172,31 @@ groups:
reviewers:
teams: [reviewers-nordic]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-nxp:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-nxp]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-samsung:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-samsung]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-eve:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-eve]
reviews:
request: 10
request: 0 # Do not auto-add
# shared-reviewers-signify disabled for now, because the reviewers-signify
# team is empty and pullapprove seems to mis-handle that badly and treats
# _all_ reviewers as being in this group.
Expand All @@ -210,39 +210,39 @@ groups:
# reviewers:
# teams: [reviewers-signify]
# reviews:
# request: 10
# request: 0 # Do not auto-add
shared-reviewers-silabs:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-silabs]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-somfy:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-somfy]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-tcl:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-tcl]
reviews:
request: 10
request: 0 # Do not auto-add
shared-reviewers-qorvo:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-qorvo]
reviews:
request: 10
request: 0 # Do not auto-add

############################################################
# Base Required Reviewers
Expand Down
71 changes: 71 additions & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
/src/platform/ASR/ @tx2rx
asr/ @tx2rx
chip-build-asr/ @tx2rx

/src/platform/Ameba/ @pankore
ameba/ @pankore
chip-build-ameba/ @pankore

/src/platform/Beken/ @zhengyaohan

*.mm @project-chip/reviewers-apple
darwin/ @project-chip/reviewers-apple
/src/darwin/ @project-chip/reviewers-apple
/src/platform/Darwin/ @project-chip/reviewers-apple
/examples/darwin-framework-tool/ @project-chip/reviewers-apple

/src/platform/ESP32/ @project-chip/reviewers-espressif
esp32/ @project-chip/reviewers-espressif
chip-build-esp32/ @project-chip/reviewers-espressif
chip-build-esp32-qemu/ @project-chip/reviewers-espressif

/src/platform/Infineon/ @ifyall
infineon/ @ifyall
chip-build-infineon/ @ifyall

/src/platform/NuttX/ @zhhyu7
chip-build-nuttx/ @zhhyu7

/src/platform/Tizen/ @arkq
tizen/ @arkq
chip-build-tizen/ @arkq
chip-build-tizen-qemu/ @arkq

*.java @project-chip/reviewers-google
*.kt @project-chip/reviewers-google
android/ @project-chip/reviewers-google
/src/examples/chef/ @project-chip/reviewers-google
/integrations/appengine/ @project-chip/reviewers-google
/integrations/cloudbuild/ @project-chip/reviewers-google
/integrations/compute_engine/ @project-chip/reviewers-google
chip-build-java/ @project-chip/reviewers-google
chip-build-android/ @project-chip/reviewers-google

/src/platform/bouffalolab/ @wy-hh
chip-build-bouffalolab/ @wy-hh

cc13xx_26xx/ @s-jain2022
cc32xx/ @s-jain2022

/src/platform/mt793x/ @pakls
nrfconnect/ @project-chip/reviewers-nordic
chip-build-nrf-platform/ @project-chip/reviewers-nordic
Zephyr/ @project-chip/reviewers-nordic @project-chip/reviewers-nxp @s07641069


nxp/ @project-chip/reviewers-nxp
chip-build-nxp/ @project-chip/reviewers-nxp
chip-build-nxp-zephyr/ @project-chip/reviewers-nxp
chip-build-k32w/ @project-chip/reviewers-nxp

qpg/ @dvdm-qorvo

silabs/ @project-chip/reviewers-silabs
chip-build-efr32/ @project-chip/reviewers-silabs

stm32/ @STYoannZamaron

telink/ @s07641069
chip-build-telink/ @s07641069

webos/ @joonhaengHeo

0 comments on commit fa0b299

Please sign in to comment.