Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: generateRequestId should accept the ExecutinContet #326

Closed
jmcdo29 opened this issue Oct 29, 2020 · 0 comments · Fixed by #327
Closed

[Feature Request]: generateRequestId should accept the ExecutinContet #326

jmcdo29 opened this issue Oct 29, 2020 · 0 comments · Fixed by #327

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Oct 29, 2020

Feature Request

Is your feature request related to a problem? Please describe.

Currently, the generateRequestId method accepts no parameters and generally creates a single id based off of the time and Math.random().

Describe the solution you'd like

The generateRequestId method should accept the ExecutionContext so that the id can be pulled off the request in the case that it's set from a middleware or guard, or if it is sent in from another application in the request header (or similar for other transports)

Teachability, Documentation, Adoption, Migration Strategy

Just add to the README that the generateRequestId now accepts the ExecutionContext as a parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(interceptor): getRequestId now optionally accepts ExecutionContext jmcdo29/ogma
1 participant
@jmcdo29