Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser]: WS #24

Closed
jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Closed

[Parser]: WS #24

jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Assignees
@jmcdo29
Labels
enhancement 🐺 A new feature to be implemented good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed ws A problem with the Websocket parser
Milestone
@ogma/namespace

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Mar 28, 2020

Now that the core functionality has been re-written, it would be great to actually include WS in the request logging.

Looking for: package under the name @ogma/platform-ws that exports a class WsInterceptorParser that extends AbstractInterceptorService from the @ogma/nestjs-module package.

The output of this is still to be determined. Some values may need to be hard-coded
@jmcdo29 jmcdo29 added help wanted 🆘 Extra attention is needed good first issue 👍 Good for newcomers enhancement 🐺 A new feature to be implemented ws A problem with the Websocket parser labels Mar 28, 2020
@jmcdo29 jmcdo29 added this to the @ogma/namespace milestone Mar 28, 2020
@jmcdo29 jmcdo29 self-assigned this Apr 17, 2020
jmcdo29 added a commit that referenced this issue Apr 19, 2020
@jmcdo29
feat(ws): implements parser for websocket
3a14bc0 
The WsParser is now written in its entirity. There are a few hardcoded values, though those could be
overriden by dev if they choose by extending the parser itself. Tests are written (P.S. writing
tests to satisfy Socket.io **and** Websocket was almost impossible, but I got it done). Only thing
to do from here is to finish off the microservice parsers 😄

fix #24
@jmcdo29 jmcdo29 mentioned this issue Apr 19, 2020
Merged
jmcdo29 added a commit that referenced this issue Apr 19, 2020
@jmcdo29
feat(ws): implements parser for websocket
9de8c96 
The WsParser is now written in its entirity. There are a few hardcoded values, though those could be
overriden by dev if they choose by extending the parser itself. Tests are written (P.S. writing
tests to satisfy Socket.io **and** Websocket was almost impossible, but I got it done). Only thing
to do from here is to finish off the microservice parsers 😄

fix #24
@jmcdo29 jmcdo29 closed this as completed Apr 21, 2020
jmcdo29 added a commit that referenced this issue Jun 20, 2021
@jmcdo29
feat(ws): implements parser for websocket
224f869 
The WsParser is now written in its entirity. There are a few hardcoded values, though those could be
overriden by dev if they choose by extending the parser itself. Tests are written (P.S. writing
tests to satisfy Socket.io **and** Websocket was almost impossible, but I got it done). Only thing
to do from here is to finish off the microservice parsers 😄

fix #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcdo29 jmcdo29

Labels
enhancement 🐺 A new feature to be implemented good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed ws A problem with the Websocket parser
Projects
None yet
Milestone
@ogma/namespace
Development

No branches or pull requests
1 participant
@jmcdo29