Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser]: GraphQL Fastify #15

Closed
jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Closed

[Parser]: GraphQL Fastify #15

jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Assignees
@jmcdo29
Labels
enhancement 🐺 A new feature to be implemented graphql-fastify 🕸️ A problem with the graphql-fastify parser Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged
Milestone
@ogma/namespace

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Mar 28, 2020

Now that the core functionality has been re-written, it would be great to actually include GraphQL in the request logging.

Looking for: package under the name @ogma/platform-graphql-fastify that exports a class GqlFastifyInterceptorParser that extends AbstractInterceptorService from the @ogma/nestjs-module package.

The output should be in the same format as the FastifyInterceptorParser.
@jmcdo29 jmcdo29 added help wanted 🆘 Extra attention is needed good first issue 👍 Good for newcomers enhancement 🐺 A new feature to be implemented graphql-fastify 🕸️ A problem with the graphql-fastify parser labels Mar 28, 2020
@jmcdo29 jmcdo29 added this to the @ogma/namespace milestone Mar 28, 2020
@jmcdo29 jmcdo29 changed the title [Parser]: GraphQL Fastify Parser [Parser]: GraphQL Fastify Mar 28, 2020
@jmcdo29 jmcdo29 self-assigned this Apr 17, 2020
@jmcdo29 jmcdo29 added Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged and removed good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed labels Apr 17, 2020
jmcdo29 added a commit that referenced this issue Apr 18, 2020
@jmcdo29
feat(gql-fastify): implements parser for GraphQL-Fastify
38ddc8a 
Due to the nature of how apollo-server-fastify works, the `getStatus` method is unusable from any of
the previous package implementations. Instead of extending and making this package require
`platform-express` or `platform-fastify` due to how the `req` object is added, all the methods are
re-implemented for ease. Small code duplication to keep the package size low.

fix #15
@jmcdo29 jmcdo29 mentioned this issue Apr 18, 2020
Merged
jmcdo29 added a commit that referenced this issue Apr 18, 2020
@jmcdo29
feat(gql-fastify): implements parser for GraphQL-Fastify
7ec49bc 
Due to the nature of how apollo-server-fastify works, the `getStatus` method is unusable from any of
the previous package implementations. Instead of extending and making this package require
`platform-express` or `platform-fastify` due to how the `req` object is added, all the methods are
re-implemented for ease. Small code duplication to keep the package size low.

fix #15
@jmcdo29 jmcdo29 closed this as completed Apr 21, 2020
jmcdo29 added a commit that referenced this issue Jun 20, 2021
@jmcdo29
feat(gql-fastify): implements parser for GraphQL-Fastify
acb3d6f 
Due to the nature of how apollo-server-fastify works, the `getStatus` method is unusable from any of
the previous package implementations. Instead of extending and making this package require
`platform-express` or `platform-fastify` due to how the `req` object is added, all the methods are
re-implemented for ease. Small code duplication to keep the package size low.

fix #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcdo29 jmcdo29

Labels
enhancement 🐺 A new feature to be implemented graphql-fastify 🕸️ A problem with the graphql-fastify parser Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged
Projects
None yet
Milestone
@ogma/namespace
Development

No branches or pull requests
1 participant
@jmcdo29