Change "forRoot" and "forRootAsync" signatures #10
Assignees
Labels
Milestone
Comments
jmcdo29
added
enhancement
help wanted 🆘
jmcdo29
added a commit
that referenced
this issue
Mar 27, 2020
Oh where to begin? This rewrite allows for the OgmaModule to manage so much more than just HTTP, and in such a way that it's almost hard to describe. With the plugin system created, so long as a class extends the `AbstractInterceptorService` **and** the class does not have any extra injections needed, any class can be provided to the `interceptor` property of the `OgmaModuleOptions` to allow for interceptor request parsing. By default, the class that is provided is a `NoopInterceptorService` that really should only be there so an error gets thrown, but something had to be there for the Nest DI ssytem to not complain. Tests are still to come to help clean out dead code, but overall, the proof of concept is there and it works! re #7 #8 #9 #10 #11
jmcdo29
added
Has PR
jmcdo29
added a commit
that referenced
this issue
Jun 20, 2021
Oh where to begin? This rewrite allows for the OgmaModule to manage so much more than just HTTP, and in such a way that it's almost hard to describe. With the plugin system created, so long as a class extends the `AbstractInterceptorService` **and** the class does not have any extra injections needed, any class can be provided to the `interceptor` property of the `OgmaModuleOptions` to allow for interceptor request parsing. By default, the class that is provided is a `NoopInterceptorService` that really should only be there so an error gets thrown, but something had to be there for the Nest DI ssytem to not complain. Tests are still to come to help clean out dead code, but overall, the proof of concept is there and it works! re #7 #8 #9 #10 #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As #9 is already a breaking change, might as well make things easier for the every day developer as well by masking the
forRoot(OgmaModule, options)functionality behind a core module that sits in the background so that all is needed isOgmaModule.forRoot(options)orOgmaModule.forRoorAsync(asyncOptions). This should be easy enough to implement for anyone who wants to manage it.The text was updated successfully, but these errors were encountered: