feat(logger): logs Symbol(name) instead of Symbol to be more clear

jmcdo29 · Aug 10, 2020 · 137db86 · 137db86
1 parent f139182
commit 137db86
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
   ],
   "scripts": {
     "preversion": "yarn run format && yarn run lint && yarn build",
-    "version": "yarn build:tools && yarn updatePeerDeps",
+    "postversion": "yarn build:tools && yarn updatePeerDeps",
     "bootstrap": "lerna bootstrap",
     "build": "lerna run build --stream",
     "build:tools": "tsc -p tools/tsconfig.json",

diff --git a/packages/logger/src/logger/ogma.ts b/packages/logger/src/logger/ogma.ts
@@ -84,7 +84,7 @@ export class Ogma {
     const seen = new WeakSet();
     return (key: string, value: any): string => {
       if (typeof value === 'symbol') {
-        return this.wrapInBrackets('Symbol');
+        return this.wrapInBrackets(value.toString());
       }
       if (typeof value === 'function') {
         return this.wrapInBrackets('Function');

diff --git a/packages/logger/test/command.spec.ts b/packages/logger/test/command.spec.ts
@@ -71,8 +71,6 @@ const ogmaHydrateTest = async (
   await expect(ogmaHydrate(hydrateArgs)).resolves.not.toThrow();
   expect(readSpy).toBeCalledWith(someFile);
   expect(writeSpy).toBeCalledTimes(1);
-  console.log(writeSpy.mock.calls[0][0].toString());
-  console.log(expectedVal);
   expect(writeSpy).toBeCalledWith(Buffer.from(expectedVal));
   readSpy.mockClear();
 };

diff --git a/packages/logger/test/ogma.spec.ts b/packages/logger/test/ogma.spec.ts
@@ -160,7 +160,7 @@ describe('Ogma Class', () => {
       expect.stringContaining('[Function]'),
     );
     expect(mockStream.write.mock.calls[0][0]).toEqual(
-      expect.stringContaining('[Symbol]'),
+      expect.stringContaining('[Symbol(hello)]'),
     );
   });
   it('should follow the context, application, and message of a json', () => {