Fix preview panel dragging experience #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview panel dragging is clunky if zoom level above 1. The higher the zoom level, the worser it is. This issue fixed by changing datatype that shifting the chunk position in preview panel from int to float. This happens probably rounding error and such
|
Looks good, that always bugged me but I never took the time to look at it 😄 |
|
Well, i think that's all i can do for now. I'm interested in adding status bar (bottom bar) that tells you what block and its coordinate your mouse cursor is pointing at, it's a very helpful little feature. But since i never code in Java (I code in C#), this is all i can do for now. I need more time to understand the Java library (such as AWT) and how your code works. Feel free to merge |
mmdanggg2
reviewed
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request do a very tiny change, but critical to the user experience.
Preview panel dragging is clunky if zoom level above 1. The higher the zoom level, the worser it is. This issue fixed by changing datatype that shifting the chunk position in preview panel from int to float. This happens probably rounding error and such.
Here we are creating a variable that representing a vector (displacement) that shift the chunk image on preview panel. If we use int for that, we would not be able to use intermediate values such as 1.2, 3.6 etc so more precision needed, and that's why we should use float instead of int for this particular variable